Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-6753: Reset menu title after location selection #10268

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

mcleinman
Copy link
Collaborator

Description

The menu title text is manually set when pushing in, but wasn't being touched when popping back out. This adds "setting the menu title" to every pop after a multihop server was selected.

Screenshot.mov

Reference

VPN-6753

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

Copy link
Member

@lesleyjanenorton lesleyjanenorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcleinman mcleinman merged commit bb6f3b0 into main Feb 20, 2025
117 checks passed
@mcleinman mcleinman deleted the vpn-6753-reset-location-title branch February 20, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants